Hi Daniele, thanks for the PR! Let me know when the Windows issue is solved :)

roast is no longer considered a virus 🎉 😀 from MS:

Open command prompt as administrator and change directory to c:\Program Files\Windows Defender
Run “MpCmdRun.exe -removedefinitions -dynamicsignatures”
Run "MpCmdRun.exe -SignatureUpdate"

I tested (and had the original reporter testing it as well) and it could run without issues ✨

@fourlastor would you be able to add a docs/distribute.md file with the necessary instructions, so we can actually merge this? We can then reference it from the readme (which I already want to break down in smaller chunks when I have time, like this would be)

Sure, a note though that construo doesn't support signing the executable yet, which is why I opened this as a draft

I think it's fine if it's well documented, and you reckon you'll add the signing to it and come back to update

Hi Daniele, is this something that can be brought to the point where it's shippable? If not, we should likely close this. WDYT?

Hi! Sorry for the long wait.

I can bring this to a shippable state, but without signing. We could still sign with apple's services (running the ci on a macos runner), but I doubt I'll be able to finish the signing part of construo anytime soon, both because I'm very unfamiliar with the process and because I physically don't have a mac to test the thing out 😅

There's been a few major changes in construo since, the most important being that I removed the integration with FooJay, as that more often than not leaded to the wrong JDK url being selected, I don't plan on adding it back as I think having a fixed url for the distribution JDK which is updated manually is a much safer and predictable process.

Let me know if this is still something that would work for jewel, and in that case I'll update the PR right away!

@fourlastor yeah that still sounds pretty valuable. As long as the readme mentions that signing is up to you, I think it's fine :)

@fourlastor is the task renaming doable? If it's a Construo thing, then we'll do it separately :) and ship this

@fourlastor is the task renaming doable? If it's a Construo thing, then we'll do it separately :) and ship this

JetBrains/JetBrainsRuntime#477

I think Construo actually just needs to fix the problem on the Mac, but so far it has been achieved. In addition, jbr on Windows and Linux already comes with a built-in jpackage, so it can coexist and package directly with Jewel. But jpackage is missing on mac, I don't know why, I'll try using construo first to see if that solves my problem